-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Payment Methods preselected by NOX after onboarding accounts #10018
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
…tomattic/woocommerce-payments into add/9973-enable-pms-from-capabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the expected outcome of the testing instructions ✅
Code looks good ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @mordeth. Left a couple of questions and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes. The code LGTM (didn't run the testing instructions). Approving it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
code looks good
tested and works as expected.
Fixes #9973
Changes proposed in this Pull Request
This PR manages the payment method capabilities preselected by NOX. It enables the corresponding payment methods and stores them in the
upe_enabled_payment_method_ids
, ensuring they appear as enabled on the WooPayments settings page.Testing instructions
Prerequisites
Testing with Test-Drive onboarding
Testing with Embedded onboarding
2 Click on WooCommerce to kickstart the WC onboarding wizard. Don't skip it, click on "Set up my store" and on the second step select "I'm already selling" and then "Yes, I'm selling online". The rest of the info doesn't matter.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge